Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: project addition by @Harshu467 #1334 #1433

Merged
merged 5 commits into from
Jun 29, 2023
Merged

chore: project addition by @Harshu467 #1334 #1433

merged 5 commits into from
Jun 29, 2023

Conversation

Harshu467
Copy link
Contributor

@Harshu467 Harshu467 commented Jun 27, 2023 •
edited
Loading

Related Issue

@Harshu467
#1334

Description

Screenshots

image

Checklist for projects addition

  • My project has contribution guidelines.
  • My project has a Code of Conduct.
  • My project has a README file.
  • My project has a License.

Ready to Merge

@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Jun 29, 2023 9:05am

@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jun 27, 2023
github-actions[bot]
github-actions bot reviewed Jun 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Harshu467! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

priyankarpal
priyankarpal requested changes Jun 27, 2023
View reviewed changes
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have added projects before so you don't need to add full code check the docs

@priyankarpal priyankarpal added the changes-required changes-required label Jun 27, 2023
@Harshu467
Copy link
Contributor Author

you have added projects before so you don't need to add full code check the docs

There were conflicts on that PR and henced I closed that PR and created nedw one , please check and merge.

@Harshu467
Copy link
Contributor Author

I am facing conflicts because my pr not merge early and other pr added which cause this conflicts as in project.json my data is added in last but because u merge other PR it takes that place and I am facing this conficts evrytime . IT is request from my side please merge it and check it

@Harshu467
Copy link
Contributor Author

I am resolving it

@Harshu467
Merge branch 'main'
307fe24 
Conflicts:
	src/DB/projects.json
@github-actions github-actions bot removed projects addition add your projects wait for reviewers wait for the maintainer labels Jun 28, 2023
@github-actions github-actions bot added projects addition add your projects wait for reviewers wait for the maintainer labels Jun 28, 2023
@Harshu467
Copy link
Contributor Author

I have resolved the conflicts, Please merge it as soon as possible

@Harshu467 Harshu467 changed the title chore: project addition by @Harshu467 #1384 chore: project addition by @Harshu467 #1334 Jun 28, 2023
@priyankarpal priyankarpal linked an issue Jun 29, 2023 that may be closed by this pull request
Data: project addition by Harshu467 #1334
Closed
3 tasks
@priyankarpal
Merge branch 'main' into Harshu467
b11f524 
Signed-off-by: Priyankar Pal  <88102392+priyankarpal@users.noreply.github.com>
@priyankarpal priyankarpal merged commit 3471def into priyankarpal:main Jun 29, 2023
@Harshu467
Copy link
Contributor Author

@priyankarpal Please Add labels of GSOC and level 1, I did not got points on GSOC leaderboard

@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jun 30, 2023
@priyankarpal priyankarpal removed gssoc23 only for Girlscript summer of code level1 small level fix for GSSoC labels Jul 7, 2023
@Harshu467 Harshu467 deleted the Harshu467 branch July 29, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@priyankarpal priyankarpal priyankarpal approved these changes

Assignees

@Harshu467 Harshu467

Labels
changes-required changes-required projects addition add your projects wait for reviewers wait for the maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data: project addition by Harshu467
2 participants
@Harshu467 @priyankarpal